From 4b497ad5e84ee33710ee01426e82a5e9e6b319ff Mon Sep 17 00:00:00 2001 From: Matthias Clasen Date: Tue, 10 Mar 2009 17:45:25 +0000 Subject: [PATCH] ::icon-press and ::icon-release are not action signals. Pointed out by * gtk/gtkentry.c: ::icon-press and ::icon-release are not action signals. Pointed out by Murray Cumming svn path=/trunk/; revision=22501 --- ChangeLog | 8 ++++++++ gtk/gtkentry.c | 6 +++--- 2 files changed, 11 insertions(+), 3 deletions(-) diff --git a/ChangeLog b/ChangeLog index 01ff062037..d02a32084f 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,11 @@ +2009-03-10 Matthias Clasen + + Bug 574622 – GtkEntry: Should we wrap icon-press and icon-release + signals? + + * gtk/gtkentry.c: ::icon-press and ::icon-release are not + action signals. Pointed out by Murray Cumming + 2009-03-04 Michael Hasselmann * gtk/gtkcomboboxentry.c (gtk_combo_box_entry_contents_changed): diff --git a/gtk/gtkentry.c b/gtk/gtkentry.c index 8ba3e422aa..be1a83e65d 100644 --- a/gtk/gtkentry.c +++ b/gtk/gtkentry.c @@ -1455,7 +1455,7 @@ gtk_entry_class_init (GtkEntryClass *class) * @icon_pos: The position of the clicked icon * @event: the button press event * - * The ::icon-press signal is emitted when an activatable icon + * The ::icon-press signal is emitted when an activatable icon * is clicked. * * Since: 2.16 @@ -1463,7 +1463,7 @@ gtk_entry_class_init (GtkEntryClass *class) signals[ICON_PRESS] = g_signal_new (I_("icon-press"), G_TYPE_FROM_CLASS (gobject_class), - G_SIGNAL_RUN_LAST | G_SIGNAL_ACTION, + G_SIGNAL_RUN_LAST, 0, NULL, NULL, _gtk_marshal_VOID__ENUM_BOXED, @@ -1485,7 +1485,7 @@ gtk_entry_class_init (GtkEntryClass *class) signals[ICON_RELEASE] = g_signal_new (I_("icon-release"), G_TYPE_FROM_CLASS (gobject_class), - G_SIGNAL_RUN_LAST | G_SIGNAL_ACTION, + G_SIGNAL_RUN_LAST, 0, NULL, NULL, _gtk_marshal_VOID__ENUM_BOXED, -- 2.30.2